New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CORE] Avoid formatted comments from being messed by non-spotless linters (especially IDE linters) #7989

Merged

zhztheplayer merged 1 commit into apache:main from zhztheplayer:wip-linter-suppress

Nov 20, 2024

+12 −14

Member

zhztheplayer commented Nov 19, 2024 •

edited

Loading

Replace spotless:off with format:off. The latter can be recognized by any Scala linters backed by scalafmt.

After the fix, Intellij's reformat shortcut (ctrl+alt+l for gnome preset) will respect the disablers.


          fixup

b6e37ea

github-actions bot added CORE VELOX labels

apache deleted a comment from github-actions bot

apache deleted a comment from github-actions bot

PHILO-HE approved these changes

View reviewed changes

Member Author

zhztheplayer commented Nov 20, 2024

@PHILO-HE Thanks!

zhztheplayer merged commit 9315835 into apache:main

47 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels